Remove FindSDL2 find-module, use sdl2-config.cmake instead
This requires SDL >= 2.0.4.
Since <https://bugzilla.libsdl.org/show_bug.cgi?id=2464> was fixed in
SDL 2.0.4, SDL behaves as a CMake "config-file package", even if it was
not itself built using CMake: it installs a sdl2-config.cmake file to
${libdir}/cmake/SDL2, which tells CMake where to find SDL's headers and
library, analogous to a pkg-config .pc file.
As a result, we no longer need to copy/paste a "find-module package"
to be able to find a system copy of SDL >= 2.0.4 with find_package(SDL2).
Find-module packages are now discouraged by the CMake developers, in
favour of having upstream projects behave as config-file packages.
This results in a small API change: FindSDL2 used to set SDL2_INCLUDE_DIR
and SDL2_LIBRARY, but the standard behaviour for config-file packages is
to set <name>_INCLUDE_DIRS and <name>_LIBRARIES. Use the CONFIG keyword
to make sure we search in config-file package mode, and will not find a
FindSDL2.cmake in some other directory that implements the old interface.
In addition to deleting redundant code, this avoids some assumptions in
FindSDL2 about the layout of a SDL installation. The current libsdl2-dev
package in Debian breaks those assumptions; this is considered a bug
and will hopefully be fixed soon, but it illustrates how fragile these
assumptions can be. We can be more robust against different installation
layouts by relying on SDL's own CMake integration.
When linking to a copy of CMake in a non-standard location, users can
now set the SDL2_DIR or CMAKE_PREFIX_PATH environment variable to point
to it; previously, these users would have used the SDL2DIR environment
variable. This continues to be unnecessary if using matching system-wide
installations of CMake and SDL2, for example both from Debian.
# Checks if a given Haskell package exists (using ghc-pkg)
# and fails if it's missing.
# Loosely based on CheckLibraryExists.cmake from CMake.
#=============================================================================
# Copyright 2002-2009 Kitware, Inc.
#
# Distributed under the OSI-approved BSD License
#
# This software is distributed WITHOUT ANY WARRANTY; without even the
# implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
# See the License for more information.
#=============================================================================
macro(CHECK_HASKELL_PACKAGE_EXISTS PACKAGE MODULE FUNCTION PARAMCOUNT)
# NOTE: MODULE, FUNCTION and PARAMCOUNT are curretly ignored.
# TODO: Either implement these or drop?
set(VARIABLE "HS_PACKAGE_${PACKAGE}")
if(NOT (${VARIABLE} EQUAL "1"))
message(STATUS "Looking for Haskell package ${PACKAGE} ...")
execute_process(COMMAND ${GHC_PKG_EXECUTABLE}
"latest"
${PACKAGE}
"--simple-output"
RESULT_VARIABLE COMMAND_RESULT
ERROR_VARIABLE BUILD_ERROR
OUTPUT_STRIP_TRAILING_WHITESPACE
OUTPUT_QUIET
)
if(${COMMAND_RESULT} EQUAL 0)
message(STATUS "Looking for Haskell package ${PACKAGE} - found")
set(${VARIABLE} "1" CACHE INTERNAL "Have package ${PACKAGE}")
file(APPEND ${CMAKE_BINARY_DIR}${CMAKE_FILES_DIRECTORY}/CMakeOutput.log
"Determining if the Haskell package ${PACKAGE} exists has passed\n\n")
else()
message(STATUS "Looking for Haskell package ${PACKAGE} - not found")
set(${VARIABLE} "0" CACHE INTERNAL "Have package ${PACKAGE}")
file(APPEND ${CMAKE_BINARY_DIR}${CMAKE_FILES_DIRECTORY}/CMakeError.log
"Determining if the Haskell package ${PACKAGE} "
"exists failed with the following output:\n"
"${BUILD_ERROR}\n\n")
message(FATAL_ERROR "Haskell package '${PACKAGE}' required")
endif()
endif()
endmacro()